Repository navigation
checkpatch.pl warning about non-permalinks to Zulip #1104
Description
Please see https://lore.kernel.org/rust-for-linux/CANiq72mrwBs_YTcBvge4ME5bwSLKbNaoFU+KZw3EfCTyGjiJ9w@mail.gmail.com/.
Please note that the checkpatch.pl maintainers will need to agree to the change.
Zulip apparently has support for permalinks incoming (or already present but not exposed through the UI). It would be ideal if the warning shows the correct link to use (if that is possible to infer from the other link) or at least point to the documentation (possibly https://chat.zulip.org/api/construct-narrow#narrows-that-use-ids) or how to do it in the UI (assuming it is ready in Zulip).
This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and a Link: tag to this issue.
Activity
BiscuitBobby commentedon Aug 22, 2024
Hello, I would like to give it a shot.
ojeda commentedon Aug 22, 2024
Sure, please go ahead!
BiscuitBobby commentedon Aug 23, 2024
Hey, wanted to clarify a few things:
ojeda commentedon Aug 24, 2024
Hmm... If there are actual links that use those domains, I guess yes. However, I have only seen links like *.zulipchat.com, so unless we know they are used/generated by Zulip, I think it would be best to avoid them.
I am not sure what the new perma-links they are introducing are, but the ones we used so far have been always of the form:
https://rust-for-linux.zulipchat.com/#narrow/stream/x/topic/x/near/455637364
In order to shorten them, I usually replace the stream and topic name and leave an
xthere as above, since what counts is the number at the end.If there is no number, and only a stream/topic name, then I think they are not perma-links, because if those change, the link is broken.
I would suggest testing the links to see if they are actual permalinks or not -- if needed, please feel free to test in our Zulip (or perhaps in a test instance they may have) creating a topic and then renaming it or similar.
Thanks!
bjorn3 commentedon Aug 24, 2024
chat.zulip.org is the zulip for development of zulip itself.
BiscuitBobby commentedon Aug 25, 2024
Thanks for clearing it up for me, will test links from rust-for-linux.zulipchat.com
BiscuitBobby commentedon Aug 25, 2024
I've sent in a patch to the mailing lists.
ojeda commentedon Aug 26, 2024
https://lore.kernel.org/rust-for-linux/20240825221806.253575-1-simeddon@gmail.com/
scripts/checkpatch.pl: check for non-permalinks to Zulip
metaspace commentedon Aug 28, 2024
I don't understand how to use this feature. Is there a button somewhere, or do I have to manually write out something like this
https://rust-for-linux.zulipchat.com/#narrow/stream/x/topic/x/with/465040682?For getting the message ID, am I supposed to cut it from the URL?
bjorn3 commentedon Aug 28, 2024
If you hover over a message and click on the three dots below each other, one of the menu options is "Copy link to message".
ojeda commentedon Aug 28, 2024
That is what I do, yeah. I think Zulip is implementing something similar for topics too.
metaspace commentedon Aug 28, 2024
That would give me a link to a specific message. I think that if I want a permalink to a topic, I have to first get the link to the message and then rewrite the URL, right?
ojeda commentedon Aug 28, 2024
No, it is a permalink; however, it would point to the first message, yes.
That is what I use -- I think it is good enough until they provide permalinks to topics.
scripts/checkpatch.pl: check for non-permalinks to Zulip
scripts/checkpatch.pl: check for non-permalinks to Zulip