You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Mention what build.rs is for and why it's commented out in Cargo.toml #308
Would it be worth removing these and just documenting how to build the parser manually in the contributing doc? I feel like it might be the more long-term solution for future edits to the parser, rather than having contributors edit the Cargo.toml each time they want to rebuild the grammar.
That could certainly be an option, but manually building it is a little tedious, especially when it can all be done in one step with Cargo. When you're making multiple changes to the grammar, I think it's more convenient.
Activity
bajr commentedon Aug 26, 2016
Would it be worth removing these and just documenting how to build the parser manually in the contributing doc? I feel like it might be the more long-term solution for future edits to the parser, rather than having contributors edit the Cargo.toml each time they want to rebuild the grammar.
selenesal commentedon Aug 26, 2016
That could certainly be an option, but manually building it is a little tedious, especially when it can all be done in one step with Cargo. When you're making multiple changes to the grammar, I think it's more convenient.
arc3x commentedon Aug 26, 2016
I think it should be left in with a note of what it is for (in code & documentation)