You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Atomizer tests use list.sort() == list.sort(), which always evaluates to None == None #68
tests/test_bng_atomizer.py contains two assertions of the form list.sort() == list.sort(), which compare the return values of list.sort(). list.sort() sorts in place and returns None, so
both sides are always None and the assertion always passes —
regardless of the actual file listing.
Locations
tests/test_bng_atomizer.py:23 (in test_atomize_flat)
tests/test_bng_atomizer.py:42 (in test_atomize_atomized)
These assertions were presumably intended to verify that the atomizer
produced the expected output filename(s) in the test output directory.
Today they verify nothing — even if the atomizer wrote the wrong files,
or no files, the test would still pass.
Suggested fix
Replace each occurrence with a real comparison, e.g.:
assertsorted(file_list) ==sorted(to_match)
Note: the test output directory (tests/test/) is reused across runs
rather than being a fresh tmp_path. Once the assertion is real,
stale artifacts from prior runs may make it fail; the fix likely also
needs to switch the output directory to a per-test tmp_path (or
clean tests/test/ at setup).
Activity
wshlavacek commentedon May 7, 2026
Bumping for indexing — the issue does not appear in https://github.com/RuleWorld/PyBioNetGen/issues despite being reachable by direct URL.
wshlavacek commentedon May 7, 2026
Closing then reopening to nudge GitHub's listing index — the issue is not appearing in the repo issues list despite being reachable by direct URL.
wshlavacek commentedon May 7, 2026
Superseded by #69 — this issue is reachable by direct URL but does not appear in the repo issues list, so I refiled with simpler formatting.
🧹 [code health improvement] Remove dead code reactionCenterGraph from…