You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When trying to extract the released tar file, it fails as follows:
+ gzip -dc ./parse_args-0.5.1.tar.gz
+ tar -xf -
tar: parse_args-0.5.1/bench/run.tcl: Cannot create symlink to ‘../teabase/run_bench.tcl’: No such file or directory
tar: parse_args-0.5.1/generic/tclstuff.h: Cannot create symlink to ‘../teabase/tclstuff.h’: No such file or directory
tar: parse_args-0.5.1/generic/tip445.h: Cannot create symlink to ‘../teabase/tip445.h’: No such file or directory
tar: Exiting with failure status due to previous errors
It appears as though it is an issue with the sub-module files missing. Should they be bundled together for the tar/zip release?
Apologies I should have added more context here. What I attempted before was to pull down the tarball as though it is the product of a make dist sort of behavior, packaging all sources together. However, after doing some research it looks like Github tags do not package the sub-modules—just whatever is in the repo.
I was working on adding the parse_args module to kitcreator and the default action is to pull a bundled source archive. However, I modified the new build script to use git and recursively clone. 😊
It seems like there is a way to do this with custom Github actions as part of the test/release cycle—but for now I am okay simply cloning directly from Github.
There is a way with github actions, doing a `make dist`, creating a github
release and uploading the make dist artifact. I've been working on it for
https://github.com/cyanogilvie/tcl-tomcrypt and it's getting there. Will
need a bit of work to bring parse_args up to speed though, I don't even
think its `make dist` really works yet.
On Thu, Jan 18, 2024 at 10:16 PM bandoti ***@***.***> wrote:
Apologies I should have added more context here. What I attempted before
was to pull down the tarball as though it is the product of a make dist
sort of behavior, packaging all sources together. However, after doing some
research it looks like the default Github tags *do not* package the
sub-modules—just whatever is in the repo.
I was working on adding the parse_args module to kitcreator and the
default action is to pull a bundled source archive. However, I modified the
new build script
<https://github.com/bandoti/kitcreator/blob/master/parse_args/build.sh>
to use git and recursively clone. 😊
It seems like there is a way to do this with custom Github actions as part
of the test/release cycle—but for now I am okay simply cloning directly
from Github.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZHPTHAZOSEXBXO4GE3OU3YPF7K5AVCNFSM6AAAAABB7Q4SA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGE2DGMZVGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
Do you know what initial steps would be required for parse_args? If time permits I can try to add the sources together in the Makefile.in and try to add a distcheck target for testing. But if you'd like to wait and add common functionality from tcl-tomcrypt I wouldn't want to step on your shoes there.
I am working on getting the tdk and teapot repositories packaged into standalone executables (almost finished there). Part of that work I split submodules for the tbcload, tclcompiler, and tclparser. I will likely have to follow suit and add similar dist targets.
If you want to take a shot at it feel free, pull requests welcome :)
The TEA machinery used in parse_args is very similar to tcl-tomcrypt, just
older because I haven't worked on it as recently. If I were to have a go
at it now (unfortunately I can't at the moment - work production crises
take precedence), the steps I would expect to make it work would be:
- update to the latest teabase.
- diff tcl-tomcrypt's Makefile.in to parse_args', and wire in teabase's
Makefile.in with the symlink trick tcl-tomcrypt uses.
- copy over the .github dir from tcl-tomcrypt and edit where appropriate
- look over the last few commits to tcl-tomcrypt which iirc were all
concerned with making this work, parse_args will probably need similar
Good luck!
Activity
cyanogilvie commentedon Jan 18, 2024
Did you clone the recursive git submodules?
The version tags are just tags, not releases, you still need the submodules to be able to build the package.
mtmcp commentedon Jan 18, 2024
Apologies I should have added more context here. What I attempted before was to pull down the tarball as though it is the product of a
make distsort of behavior, packaging all sources together. However, after doing some research it looks like Github tags do not package the sub-modules—just whatever is in the repo.I was working on adding the
parse_argsmodule to kitcreator and the default action is to pull a bundled source archive. However, I modified the new build script to use git and recursively clone. 😊It seems like there is a way to do this with custom Github actions as part of the test/release cycle—but for now I am okay simply cloning directly from Github.
cyanogilvie commentedon Jan 18, 2024
mtmcp commentedon Jan 18, 2024
Do you know what initial steps would be required for
parse_args? If time permits I can try to add the sources together in theMakefile.inand try to add adistchecktarget for testing. But if you'd like to wait and add common functionality from tcl-tomcrypt I wouldn't want to step on your shoes there.I am working on getting the
tdkandteapotrepositories packaged into standalone executables (almost finished there). Part of that work I split submodules for thetbcload,tclcompiler, andtclparser. I will likely have to follow suit and add similardisttargets.cyanogilvie commentedon Jan 18, 2024
mtmcp commentedon Jan 18, 2024
Okay sounds good—I'll post an update here when I make progress. Thanks.
mtmcp commentedon Mar 4, 2024
I haven't forgotten about this! Just working on wrapping up some other tasks and I will be back on it shortly. :)