Repository navigation
Conversation
The same-newness files must have equal modification times, but separate touch calls can straddle a second boundary and make the destination newer. This causes --update to skip it unexpectedly. Copy the source timestamps to the destination explicitly.
iamanaws
force-pushed
the
bugfix/exclude-test-timestamps
branch
from
October 7, 2026 22:12
09df93e to
af7e8a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
same-newnessfiles are created with separatetouch()calls. If those calls cross a second boundary, the destination becomes newer and--updateskips it, causing the test to fail.Copy the source timestamps to the destination explicitly so the equal-age case is deterministic.
Validated on Linux with rsync 3.5.0: a reproducer forcing each touch across a second boundary fails before the fix and passes afterward. The genuinely newer source and destination cases still pass. The full suite was not run.
AI assistance was used to prepare and validate this fix.