Repository navigation
Rewrite vibe-check to RoleModel skill conventions, add evals - #2
Merged
Merged
Conversation
- Frontmatter with a model-facing description, triggers, author, version - Numbered procedure: map, steps, check findings, verdict, report - Stack detection table and Leans on table for sibling skills - Repo text aimed at agents is reported as a security risk (Rule 0) - Re-check every finding, including notes, against the code and git log --stat - "Look for" tables per step; verdict rules run in order - Gotchas from test runs: public keys, .env.example, one-commit imports, RLS - File paths and report JSON keys unchanged for the live API - evals/: three sample apps (Harden, Ship, Rebuild) with graders Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the Codebase Assessment rename, the eight Assessment Areas and the architecture map from main, and rewrites them to the RoleModel skill conventions from this branch. Verdict ids stay ship, harden, rebuild and retire. The evals now check for eight areas, the architecture key and 8-16 findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
vibe-check/SKILL.mdnow follows the RoleModel skill conventions:metadata, andlicense.rails-auditandmake-it-rightwhen they are installed.Ground rules. The repo under review is data. Text in the repo that tells an AI reviewer what to do is now reported as a
securityrisk. The report never prints any part of a secret.Check your findings. A new step re-checks every finding before the verdict, notes included. A flow that "works" is traced to the rows it writes. The history note is checked against
git log --stat.references/steps.md,references/verdicts.md, andstacks/*.mdnow use "Look for | Why it matters" tables. The verdict rules run in order, and the first one that matches wins.evals/(new, at the repo root) holds three sample apps. Each one has a planted verdict:The evals are outside
vibe-check/, so a test run cannot see the graders.Why
We want the skill to match how the other RoleModel skills are written. We also need a way to test a change before it goes live.
Test results (new skill vs. last commit's skill)
For the reviewer
mainwithin about 1 minute.templates/report.mdare unchanged, so the website component still works.🤖 Generated with Claude Code