Skip to content

HTTP URLs opened from bookmarks should not be upgraded to HTTPS #17

Open

Description

@fmarier

Here's another case that seems to be upgraded unnecessarily:

  1. bookmark an HTTP-only site, for example http://bholley.net/blog/2015/mozpromise.html
  2. use the awesomebar to navigate to it
  3. notice how you are taken to https://bholley.net/blog/2015/mozpromise.html

Activity

  1. fmarier commented on Dec 22, 2017

    @fmarier
    Author

    Actually, the problem seems larger than the above scenario.

    On 0.4.3, if I do the following

    1. type Ctrl+l to focus the address bar
    2. clear the existing contents
    3. type "http://example.com"

    then I am taken to "https://example.com" instead of "http://example.com".

  2. Rob--W commented on Dec 22, 2017

    @Rob--W
    Owner

    This is due to limitations of the extension API. For bookmarks I could try to detect whether a host name is bookmarked, and if if so, if there is at least one https-URL before redirecting.

    For the case of non-bookmarked domains, there is no side channel that I can use to determine whether the user typed "http://" or nothing.
    Would the ability to forcidbly navigate to http (e.g. typing "h example.com" -> "http://example.com") be a good option for you?

  3. cben commented on Dec 22, 2017

    @cben
  4. Rob--W commented on Dec 22, 2017

    @Rob--W
    Owner

    @cben That bug hasn't been closed yet. Though even if the linked bugs get resolved (i.e. we can distinguish typed navigations from non-typed navigations), then we still have the problem of detecting typed example.com from typed http://example.com.

  5. fmarier commented on Dec 22, 2017

    @fmarier
    Author

    I'm starting to suspect that perhaps the best way to replicate the original behaviour would be to use the code from the original add-on to make a patch in gecko directly (behind an about:config pref).

  6. Rob--W commented on Dec 31, 2019

    @Rob--W
    Owner

    (this is off-topic)

    BTW, another useful extension to create would be one that goes through all bookmarks and sees if https is available for them. The only trick is that a screenshot would have to be taken of both the http and https versions to compare them. Some sites will load on https, but the content is broken.

    This is something that can easily be done with an extension. But instead of using a screenshot, I would suggest to just confirm that the request succeeds successfully, or at most compare the response text. Comparing by screenshots is complicated and easily defeated when the result has dynamic content, e.g. embedded adverts.

    To get started with developing extensions, see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions
    and for your specific use case, see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_the_Bookmarks_API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions