Repository navigation
ci(pr): pin Test job runner to ubuntu-24.04 (RIG-9206) - #12
Closed
rigel-mintaka wants to merge 2 commits into
Conversation
Co-authored-by: Matt Wilkinson <matt@rigel.build>
The ubuntu-latest image moved to 26.04, which Playwright does not support for chromium. The Test job fails at browser install on every PR. Pinning the runner keeps the Test job on a supported image until Playwright catches up. Stacked on virtual#10 (RIG-9272 chain) so the hk pre-push gate sees hk.pkl. Refs RIG-9206 Co-authored-by: Matt Wilkinson <matt@rigel.build>
2 of 4 tasks
2 of 4 tasks
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
Collaborator
Author
rigel-mintaka
deleted the
dependencies/rig-9206-pin-test-job-runner-to-ubuntu-24-04
branch
November 11, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
rigel-release🎯 Changes
Pins the
Testjob in.github/workflows/pr.ymltoubuntu-24.04. Every other job keepsubuntu-latest.ubuntu-latestnow resolves to an image Playwright does not support for chromium. TheTestjob fails atpnpm exec playwright install chromiumon every PR:A runner pin is one line. A Playwright bump would change the lockfile and the browser set. Matt's ruling for this lane is the smaller fix. A later bump can replace the pin.
Stacked on #10. This branch sits on the #10 tip (
29e6943a), which reverts the GitHub Release upload (RIG-9386) and keepshk.pkl. The repo pre-push gate needshk.pkl, which the #10 chain carries. Merge #10 first, or rebase this PR ontorigel-releaseonce #10 lands.Verification:
yq -e '.jobs.test."runs-on"' .github/workflows/pr.ymlreturnsubuntu-24.04. The diff against #10 is one line. CI on this PR is the check: theTestjob should get past browser install.✅ Checklist
pnpm run test:pr. Not run locally: CI is the verification for this lane.🚀 Release Impact
Refs RIG-9206
Co-authored-by: Matt Wilkinson matt@rigel.build