Skip to content

Wrong dictionary NPE guard #151

Open

Description

@aploskov

core/jdiameter/impl/src/main/java/org/jdiameter/client/impl/fsm/PeerFSMImpl.java:343
contains diameter != null, but at the previous line ValidatorLevel incomingLevel = dictionary.getReceiveLevel();. It's not a problem, until dictionary is a singleton, but may produce bugs, if the dictionary implementation will change.

I think, you should inline incoming level and change the debug message in the else statement.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions