Skip to content

Always add rcon arguments, not just for windows - #132

Merged
grilledham merged 1 commit into
developfrom
wrapper_rcon
Nov 10, 2024
Merged

grilledham merged 1 commit into
developfrom
wrapper_rcon

Conversation

@grilledham

Copy link
Copy Markdown
Contributor

No description provided.

@grilledham
grilledham merged commit 67d6b37 into develop Nov 10, 2024
@grilledham
grilledham deleted the wrapper_rcon branch November 10, 2024 15:00
grilledham pushed a commit that referenced this pull request Oct 22, 2026
* Read rcon password from settings.json

The rcon password was a hardcoded constant, so every server started with
the same, publicly known password. Since #132 this also applies on Linux.

Add an optional rcon_password setting to the wrapper's settings.json. If
it's empty or missing, a random password is generated each time the
wrapper starts, so existing settings files keep working. The password is
also no longer written to the wrapper log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Bind rcon to localhost only

--rcon-port makes Factorio listen for rcon on all interfaces. The wrapper
only connects to rcon on 127.0.0.1, so bind it there and keep it off the
public network.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: lex <lex@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant