Repository navigation
Conversation
|
Review changes with Changed Files
|
Member
|
CI will fail for this one too. If you have a chance to rebase your open PRs onto origin/main that should let CI pass, with the image change I pushed. |
joanise
reviewed
Oct 24, 2026
joanise
left a comment
joanise
left a comment
Member
There was a problem hiding this comment.
Looks good, thank you! Thanks for finding what was causing the errors in the first place. The code looks good and CI passes (in a separate rebased branch). Next week I'll test the integration with Studio-Web to complete my review.
Happy to see these pull requests from you -- I'm curious, are you using the studio for some Indigenous language projects or for some other projects? We're always interested in finding out what our tools are used for if you're willing to share.
the8thbit
force-pushed
the
fix/filter-invalid-xml-characters-279
branch
from
October 24, 2026 03:38
55627ab to
3a22d58
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Remove XML 1.0-invalid characters from plain-text lines before building ReadAlong XML. Escape characters such as U+001B no longer produce XML that the back-end rejects. Valid Unicode, XML escaping, tabs, line endings, and the existing page/paragraph conventions are preserved.
Fixes?
Fixes #279.
Tests added?
Parameterized cases cover forbidden control characters, surrogate code points, U+FFFE, and U+FFFF. A control case preserves Indigenous-language characters, combining marks, supplementary Unicode, tabs, and XML escaping.
How to test?
pytest tests/test_make_xml_cli.py -qIndependent review reran all 51 tests in this file successfully. Applicable formatting, lint, and type-check hooks pass.
Version change?
Patch; no version files changed.