Repository navigation
Updates backgrounds and resolutions in line with the MATLAB - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #99. It additionally:
test_examples.pywhich ensures that all examples run without error (exceptconvert_rascal, seeconvert_rascalexample doesn't work when called programmatically #102)I've compared the results of the new
DSPC_data_backgroundandDSPC_function_backgroundexamples to those in the MATLAB and found that they give the same results between languages.The output result has had backgroundParams removed from the contrastParams sub struct, with backgrounds added to the main result struct.done in Updates C++ and some unit tests #97ALL data files in the input problemStruct have been extended to EXACTLY six columns. Any empty columns are filled with zero values.done in Updates C++ and some unit tests #97The field contrastBackgroundTypes has been added to problemStructdone in Updates C++ and some unit tests #97