[arwelHughes]

This PR fixes two issues in RasCAL2:

• Closes Issue Possible "Use resampling" bug RasCAL-2#215: This bug was caused by the total range for the SLD plots not being sufficient when large roughness' are used in the last layer if standard layer models. 'makeSLDProfile' has been modified to extend the range of the profile to cover the 99% interval of the outer error function.

• Closes Issue Align multiple SLD profiles to bulk in OR bulk out RasCAL-2#205: SLD profiles should always be aligned to the substrate edge. This happens automatically for substrate/liquid profiles, but for air/substrate samples should be aligned to the other end. To fix this, 'plotRefSLD' has been modified to align the substrates in A/L projects by padding the start of the SLD's.

[arwelHughes]

Hi Paul, Yes, that seems reasonable, thanks... A

________________________________ From: Paul Sharp ***@***.***> Sent: 19 June 2026 4:10 PM To: RascalSoftware/RAT ***@***.***> Cc: Hughes, Arwel (STFC,RAL,ISIS) ***@***.***>; Author ***@***.***> Subject: Re: [RascalSoftware/RAT] Modified SLD profiles. (PR #440) @DrPaulSharp commented on this pull request. One point here, assuming all is well, I'll work to merging this work through #443<#443>.

________________________________ In targetFunctions/common/makeSLDProfiles/makeSLDProfile.m<#440 (comment)>:

- for i = 1:numberOfLayers

- layerThickness = layers(i,1); - layerSLD = layers(i,2); - layerRoughness = roughnessValues(i); - nextLayerRoughness = roughnessValues(i+1); - thisBoxCentre = lastBoxEdge + (0.5 * layerThickness); - thisBox = asymconvstep(x,layerThickness,thisBoxCentre,layerRoughness,nextLayerRoughness,layerSLD); - Lays(:,i+(numberOfLayers*(n-1))) = thisBox; - lastBoxEdge = thisBoxCentre + (0.5 * layerThickness); + outerLayerCentre = totalThickness - (layers(end,1)/2); + + % Find the point which covers 99% of the outer error function.. + outerLayerTailLim = (erfcinv(0.01) * sqrt(2) * layers(end,3)) + outerLayerCentre; + + % We need to make sure the total SLD range includes this... + outerLayerTailExtension = outerLayerTailLim - outerLayerCentre; The variables outerLayerCentre and outerLayerTailLim is only used here, so we should calculate outerLayerTailExtension directly by replacing lines 10, 13 and 16 with: outerLayerTailExtension = (erfcinv(0.01) * sqrt(2) * layers(end,3)); — Reply to this email directly, view it on GitHub<#440?email_source=notifications&email_token=AGMNVXQ6B6XK36LHHFHYCND5AVJUZA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINJTGM2DKNJXGUYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4533455750>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGMNVXVSK45UGCSB7EJIDFD5AVJUZAVCNFSNUABFKJSXA33TNF2G64TZHMZDMOJTHA4TAMBZHNEXG43VMU5TINJQGI2TEMBVGA32C5QC>. You are receiving this because you authored the thread.Message ID: ***@***.***>