Skip to content

chore: require PHP 7.4 - #19

Merged
donatj merged 9 commits into
masterfrom
chore/php-7.4-mddoc-0.13
Oct 24, 2026
Merged

donatj merged 9 commits into
masterfrom
chore/php-7.4-mddoc-0.13

Conversation

@donatj

@donatj donatj commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

This package needs PHP 7.4 to use MDDoc 0.14.1. Its Composer metadata also lacked a clear description and search keywords.

Changes:

  • Raise the minimum PHP version to 7.4.
  • Add MDDoc 0.14.1 as a development dependency.
  • Regenerate the README with MDDoc 0.14.1.
  • Remove PHP 7.2 and 7.3 from continuous integration.
  • Verify generated documentation in continuous integration.
  • Improve the Composer description and keywords.
  • Enable Composer package sorting.

Validation:

  • php -l src/array.php
  • composer validate --strict --no-check-publish
  • vendor/bin/mddoc --dry-run
  • vendor/bin/phpunit --do-not-cache-result
  • Ruby YAML parsing
  • git diff --check

@donatj

donatj commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

@copilot run mddoc and commit the changes.

Co-authored-by: donatj <133747+donatj@users.noreply.github.com>

Copilot AI commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

@copilot run mddoc and commit the changes.

Ran MDDoc 0.14.1 and committed the generated README changes in 9f55158.

@donatj
donatj marked this pull request as ready for review October 24, 2026 11:21
Copilot AI balanced review requested due to automatic review settings October 24, 2026 11:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency, documentation, and CI changes are consistent, with no unresolved blocking findings.

No open issues 🎉

What changed in this PR

This PR raises the package’s minimum PHP version to 7.4 and aligns development tooling, generated documentation, and CI with that requirement.

Changes:

  • Require PHP 7.4, add MDDoc ^0.14.1, and drop PHPUnit 8 support.
  • Regenerate the README and add documentation verification to CI while removing PHP 7.2 and 7.3 jobs.
  • Improve Composer metadata and enable package sorting.
File Description
README.md Update the PHP requirement and generated API documentation formatting.
composer.json Update dependencies and package metadata; enable package sorting.
.github/​workflows/​ci.yml Remove unsupported PHP versions and verify generated documentation.

Review effort: Balanced

@donatj
donatj merged commit 2391630 into master Oct 24, 2026
17 checks passed
@donatj
donatj deleted the chore/php-7.4-mddoc-0.13 branch October 24, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants