Repository navigation
fix(mongodb): the documents toolbar wraps in a narrow pane instead of overflowing - #1825
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by opening a Mongo collection in a debug build at a 1028 px window (sidebar open): the filter bar (search, Apply, Clear, Table / Tree / JSON / Cards, Aggregation, Indexes, Console, Add Document) is one
Rowand needs about 1200 px. The search field is the only flexible part, so it was squeezed to nothing and the rest ran 196 px past the pane (the red / yellow overflow strip, andRenderFlex overflowedin debug).Below 1200 px of bar width the tools now go to a second row that wraps (view switcher, the three buttons, Add Document); wider, the single row is unchanged. Checked in the running app at 1028 px: no overflow, the search field has its full width.
No new test: the view needs a live
MongoConnection, and the e2e harness replaces it. Not run locally (analyzer clean), CI will.