Skip to content

test(charts): the pie lays out at 600 and 1600 px (#1160) - #1199

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1160-pie-legend-colours
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1160-pie-legend-colours

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1160

Changes

  • Widget tests: the pie lays out without exceptions at 600 px and at 1600 px wide.

Already on dev before this PR

  • Radius from the pane size (LayoutBuilder), donut style.
  • Legend beside the donut (wide) or below it (narrow), with hover linking legend row and slice.
  • Default Top N for the pie (ChartData.pieTopN, Top 8 + Other); colours tinted from round to round so they stay distinct.
  • Slice labels with contrast against the slice colour.
  • The test for Top 8 with Other, distinct colours and a legend.

Not covered here

  • The pie filling the pane is not measured; the test checks only for layout exceptions. The issue stays open until someone checks the size visually or with a size assertion.

The donut is sized from the pane by LayoutBuilder and the legend moves below it
on a narrow pane. These two widths check that neither clips or overflows.
@github-actions github-actions Bot added bug Something isn't working ui User interface components and widgets data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring labels Oct 9, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 18cac8b into dev Oct 9, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1160-pie-legend-colours branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant