Repository navigation
Conversation
|
I think a |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
So currently this doesn't make use of the device-side storage in cuBLAS and rocBLAS. If we like the overall approach, I will then add some specializations via extensions here and elsewhere that will use them. |
| elseif β === Zero() || β === false | ||
| scale!(y, x, convert(T, α)) | ||
| else | ||
| LinearAlgebra.axpby!(convert(T, α), x, convert(T, β), y) |
There was a problem hiding this comment.
I think these types of convert(T, ...) calls will have to be updated to support Scalar inputs, and to then call the corresponding BLAS library call. This can be done via package extensions, but it would be good to contemplate if we can do without, or at least as much as possible.
There was a problem hiding this comment.
I think for a Scalar backed by a Vector these calls should just convert to the "number within" since CPU BLAS doesn't have this pointer mode at all. For all other (e.g. GPU based) array types it can stay as-is, I think?
|
Fail looks like an Enzyme bug, EnzymeAD/Enzyme.jl#4051 |
|
or rather actually a julia problem, where 1.13.4 broke otherwise functional code in 1.13.3. I'd rec to pinning 1.13.3 for now |
Idea is to allow us to take advantage of JuliaGPU/CUDA.jl#2616 and the AMDGPU equivalent by avoiding round-trip copies when using VI with GPU arrays.