Skip to content

from builtins import itervalues doesn't work with python 2.7 - #302

Closed
theoden-dd wants to merge 1 commit into
PythonCharmers:masterfrom
theoden-dd:master
Closed

theoden-dd wants to merge 1 commit into
PythonCharmers:masterfrom
theoden-dd:master

Conversation

@theoden-dd

Copy link
Copy Markdown

I hope auto-trimmed spaces are OK.

@Uzume

Uzume commented Dec 14, 2017

Copy link
Copy Markdown

I noticed the same documentation issue on the website:
Cheat Sheet: Writing Python 2-3 compatible code Dictionaries Iterating through dict keys/values/items

@sfdye

sfdye commented Jun 14, 2020

Copy link
Copy Markdown
Collaborator

Sorry could you remove the non essential changes, it's very hard to review

@Uzume

Uzume commented Jun 14, 2020 •

Copy link
Copy Markdown

This was fixed with 9fcde90 (and made it into 0.17.0), however, the website still reports the same older broken content and needs to be updated or regenerated from source.

Please have these updated from docs/compatible_idioms.rst:

This:

from builtins import itervalues

needs to be changed to:

from future.utils import itervalues

Since the change was made in 2018, it appears the website has not been updated in years; at least not since 2016-10-27 and the 0.16.0 release based upon:

This also seems to affect other things that still have the same error in them, like:

Thank you.

@sfdye

sfdye commented Jun 14, 2020 •

Copy link
Copy Markdown
Collaborator

I see, thanks! For website update we have #511 to track, which will be fixed very soon.

@sfdye sfdye closed this Jun 14, 2020
@Uzume Uzume mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants