Repository navigation
Conversation
Lp_ST raised a NameError on the undefined firstChNum and, past it, a TypeError, since it called fractional_octave_frequencies with minFreq and maxFreq instead of freqRange. The calibration check now reads the first channel through channels.mapping. The average over the microphone positions was the arithmetic mean of the levels. ISO 3741:1999, Equation (9), asks for the energy mean, while the standard deviation of Equation (6) is taken around the arithmetic mean, as before. Tests check both means with two tones at 80 and 70 dB, and that an uncalibrated signal is rejected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytta.iso3741.Lp_STcould not be called. It stopped with a NameError on the undefinedfirstChNumand, past that line, with a TypeError, since it passedminFreqandmaxFreqtofractional_octave_frequencies, which takesfreqRange. This pull request fixes both. The calibration check now reads the first channel throughchannels.mapping.It also fixes the average over the microphone positions, which was the arithmetic mean of the levels. ISO 3741:1999, 8.3, Equation (9), asks for the energy mean, Lp = 10 lg(1/NM Σ 10^(0.1 Lpi)). The standard deviation of 8.1.5, Equation (6), is taken around the arithmetic mean of the levels and stays as it was.
The tests in
tests/test_iso3741_lp_st.py:The background noise correction K1 of 8.1.4 is still not applied, as the docstring states. #85 adds the sound power level to the same module. The two touch different functions.
Checked with Python 3.12, numpy 1.26 and scipy 1.17. The 7 failures of
development(3 intest_h5io.py, 4 intest_pyttasave.py) are the same with and without this change.Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com