Repository navigation
Error with RoomAnalysis #40
Description
I tried the reverberation_time example, and I get the following error:
[/usr/local/lib/python3.7/dist-packages/scipy/signal/filter_design.py](https://localhost:8080/#) in iirfilter(N, Wn, rp, rs, btype, analog, ftype, output, fs)
2344 if not analog:
2345 if numpy.any(Wn <= 0) or numpy.any(Wn >= 1):
-> 2346 raise ValueError("Digital filter critical frequencies "
2347 "must be 0 < Wn < 1")
2348 fs = 2.0
ValueError: Digital filter critical frequencies must be 0 < Wn < 1Any hints?
Best,
N
Activity
the-drunk-coder commentedon Jun 9, 2022
Here's the full traceback:
Chum4k3r commentedon Jun 9, 2022
Hello @the-drunk-coder, thank you for the traceback and your interest in pytta.
My time for pytta lies only on the weekends, when there's spare time, so I won't be able to give you some more hints right away. If you don't mind trying to run it from de code in development and get us the traceback, we might coordinate a solution to this issue.
Thanks again, and feel free to question as much as you want!
the-drunk-coder commentedon Jun 9, 2022
Hi @Chum4k3r, no worries :)
The traceback above is from the latest development version, I checked it out this morning, in a conda environment generated from the
requirements.yml.I played around with it and tried to scale the edge frequencies to [0, 1] (by dividing them by
samplerate//2, but now I get a different error, so I'm not sure whether that was the right way to go ...Best,
Niklas
Chum4k3r commentedon Jun 9, 2022
Ok, from the scipy.signal.iirfilter documentation, it seems that the parameter
fsreceives aNone, instead of the actual.samplingRateproperty.If it is None, it is coming from the
OctFilterclass as asamplingRate == None.Can you debug the filtering steps to check?
This is the critical code line of the filtering process.
best,
João Vitor
the-drunk-coder commentedon Jun 10, 2022
That doesn't seem to be it, the samplerate is passed correctly to the OctFilter constructor.
I also tried the following (mentioned above but here's the details):
In
filter.py, line 102, add:edges = edges / (samplingRate//2)to normalize the frequencies to [0,1]This leaves me with another error, though:
aguirreSL commentedon Oct 31, 2026
I tried this again on the current
developmentbranch (1d30852) with Python 3.12, numpy 1.26 and scipy 1.17.examples/reverberation_time.pyruns to the end and no longer raises theValueErrorfromscipy.signal.butter. If it still fails for you, a traceback fromdevelopmentwould help. Otherwise I think this issue can be closed.