Skip to content

SignalObj.uncalibrate method #14

Open

Description

@mtslazarin
No description provided.

Activity

  1. Chum4k3r commented on Jul 8, 2021

    @Chum4k3r
    Collaborator

    I believe the SignalObj.timeSignal data should be kept in full range values and have the calibration factor applied only for visualization purposes, e.g. .plot_time(), .plot_freq(), etc.

    Thus, there will be no need for removing the calibration.

  2. aguirreSL commented on Oct 31, 2026

    @aguirreSL

    #62 adds SignalObj.uncalibrate, which divides the samples by the correction factor and sets the channel back to full scale. It keeps the current design, where calibration changes the samples. Keeping the samples at full scale and applying the factor only when plotting, as suggested above, would change what timeSignal returns for everyone, so I left that for a separate discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions