You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the SignalObj.timeSignal data should be kept in full range values and have the calibration factor applied only for visualization purposes, e.g. .plot_time(), .plot_freq(), etc.
Thus, there will be no need for removing the calibration.
#62 adds SignalObj.uncalibrate, which divides the samples by the correction factor and sets the channel back to full scale. It keeps the current design, where calibration changes the samples. Keeping the samples at full scale and applying the factor only when plotting, as suggested above, would change what timeSignal returns for everyone, so I left that for a separate discussion.
Activity
Chum4k3r commentedon Jul 8, 2021
I believe the
SignalObj.timeSignaldata should be kept in full range values and have the calibration factor applied only for visualization purposes, e.g..plot_time(),.plot_freq(), etc.Thus, there will be no need for removing the calibration.
aguirreSL commentedon Oct 31, 2026
#62 adds
SignalObj.uncalibrate, which divides the samples by the correction factor and sets the channel back to full scale. It keeps the current design, where calibration changes the samples. Keeping the samples at full scale and applying the factor only when plotting, as suggested above, would change whattimeSignalreturns for everyone, so I left that for a separate discussion.