You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
search_order in this context would most likely be better named “_search_columns” (although we could keep search_order as an alias), and search_columns could be a property that returns all columns if search_columns isn’t specified.
After some consideration, I think adding this as a TableHeadings setting is appropriate… enable_search_filtering. I’ll set to False by default, like the other new ones in WIP.
That way it doesn’t change behavior unless desired.
Activity
ssweber commentedon May 29, 2023
This is sorta what Thunderbird uses for its “quick filter”, which I find even more useful than its search function
Thunderbird persists the filter through sorts, only clearing it after leaving the folder and coming back.
So we could persist in through sg.Table sorts, but clear the search input during any requery.
ssweber commentedon May 29, 2023
search_order in this context would most likely be better named “_search_columns” (although we could keep search_order as an alias), and search_columns could be a property that returns all columns if search_columns isn’t specified.
ssweber commentedon May 29, 2023
If you want, this could be in addition to search+return == set to next result.
Current search behavior would never go to the next search_order column if the first has any results, did it? It just loops to beginning, correct?
ssweber commentedon May 31, 2023
This isn't that bad of a diff. Would you want the combo/listbox/sliders filtered as well? I think it may just be a nice Table-view addition. This is the filtering-search branch
I didn't try to keep the filter persistent through sorts/first/prev/next/last. I sorta like the behavior:
python_parCkiIm63.mp4
ssweber commentedon May 31, 2023
However, the ability to keep clicking 'Return' is lost here.
Keeping it persistent is fairly easy. Will reset search during virtual pk insert, save, and requery?
ssweber commentedon May 31, 2023
Updated:
python_v0iMc8Qvd2.mp4
ssweber commentedon Jun 1, 2023
After some consideration, I think adding this as a TableHeadings setting is appropriate… enable_search_filtering. I’ll set to False by default, like the other new ones in WIP.
That way it doesn’t change behavior unless desired.
PySimpleSQL commentedon Jun 3, 2023