Skip to content

Bug in _mysql_field_to_python - #346

Merged
methane merged 1 commit into
PyMySQL:masterfrom
fried:master
Mar 19, 2019
Merged

methane merged 1 commit into
PyMySQL:masterfrom
fried:master

Conversation

@fried

@fried fried commented Mar 18, 2019 •

Copy link
Copy Markdown
Contributor

when callback conversion is used the value is always passed as Str.

Missing break;

Turns out this was just reported. #343

when callback conversion is used the value is always passed as Str instead of bytes in python3.
@codecov

codecov Bot commented Mar 18, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          13       13           
  Lines        1556     1556           
=======================================
  Hits         1356     1356           
  Misses        200      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a67ae2...cafcddb. Read the comment docs.

@methane
methane merged commit e04c597 into PyMySQL:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants