Skip to content

FileVideoStream wait time #92

Closed
Closed

Description

@itsMeBrice

The time to wait if the queue is Full in FileVideoStream is said by a comment to be 10 ms but actually is 100 ms. This can lead to problems when the consumer is faster than the producer.

Activity

  1. itsMeBrice commented on Oct 4, 2018

    @itsMeBrice
    Author

    Additionally, if i try to read() of a stopped FileVideoStream the script will never leave read(). Maybe check if the thread is still running before extracting from the queue?

  2. itsMeBrice commented on Oct 5, 2018

    @itsMeBrice
    Author

    My fix is to adapt the read() function of the FileVideoStream class as follows:

    def read(self):
    	# return next frame in the queue
    	if self.running():
    		return self.Q.get()
    	else:
    		return False
    

    Not too sure whether this is a pretty or even good solution but it fixes the thread freezing the whole application when trying to read from an empty queue that will never have any additional entrys.

  3. jrosebr1 commented on Oct 29, 2018

    @jrosebr1
    Contributor

    This has been resolved by #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions