Skip to content

Adding basic support for CASEZ statements - #57

Merged
shtaxxx merged 1 commit into
developfrom
unknown repository
Mar 12, 2020
Merged

shtaxxx merged 1 commit into
developfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 3, 2020

Copy link
Copy Markdown

I'm using Pyverilog to obtain the boundary description of a Verilog module (ports, parameters, etc.) - unfortunately when a 'CASEZ' statement is used, it it causing the AST parser to fail:

Generating LALR tables
WARNING: 183 shift/reduce conflicts
Syntax error
Traceback (most recent call last):
  File "test.py", line 13, in <module>
    file.parse()
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/parser.py", line 2274, in parse
    ast = self.parser.parse(text, debug=debug)
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/parser.py", line 77, in parse
    return self.parser.parse(text, lexer=self.lexer, debug=debug)
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/ply/yacc.py", line 265, in parse
    return self.parseopt_notrack(input,lexer,debug,tracking,tokenfunc)
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/ply/yacc.py", line 1047, in parseopt_notrack
    tok = self.errorfunc(errtoken)
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/parser.py", line 2246, in p_error
    self._coord(p.lineno))
  File ".../venv/lib/python3.7/site-packages/pyverilog/vparser/plyparser.py", line 55, in _parse_error
    raise ParseError("%s: %s" % (coord, msg))
pyverilog.vparser.plyparser.ParseError: :6: before: (

This can be triggered by a module definition as simple as:

module my_mod(input clk, input rst, input [3:0] vector, output reg [3:0] data);
always @(posedge clk or posedge rst) begin
    if (rst) begin
        data <= 1'b0;
    end else begin
        casez (vector)
            4'b??1?: data <= vector;
            4'b?1??: data <= ~vector;
            4'b1??0: data <= 4'h0;
            default: data <= 4'hF;
        endcase
    end
end
endmodule

The fix I'm pushing is just enough to get the AST parse to complete - I have not widely tested it, nor pushed the changes into the code generator.

@shtaxxx
shtaxxx merged commit 59a8dc6 into PyHDI:develop Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant