Repository navigation
Fix #167: Check if stdin is a terminal before calling termios on it - #198
Merged
Merged
Conversation
…ose operations fail on a pipe, ie when running pytest. Fix for #167, tests fail on macOS.
clint-lawrence
approved these changes
Jul 22, 2024
clint-lawrence
left a comment
clint-lawrence
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Ages ago, I had tried to keep this running on MacOS and Linux, so more than happy for small fixes to get that back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On *nix, check if stdin is a terminal before calling termios on it as those operations fail on a pipe, ie when running pytest.