Repository navigation
Verify Toonstruck - #839
Merged
Merged
Conversation
…ivbe, enable stereo sound, limit cpu speed to make gift-o-matic playable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying Toonstruck (1996) (Burst Studios)
Original PR: #253
Fix PR: #440
Checklist
Have adequate installation instructions been provided to match any config files in the DOSZ?
TOONSTRK.CFGis needed in the DOSZ because of its CD path. It also has audio and video settings, but video is set with an automatic detection process rather than chosen, so I didn't bother to give instructions repeating its contents for manually editing, just embedded data.I removed
TOONSTRK.CFGandSETUP.INIfrom the DOSC since they were redundant, and used XOR patches for the two large files that get created by video setup,UNIVBE.DRVandUVCONFIG.DAT. The patches compare againstUVCONFIG.EXE(the files do not directly exist on the discs, despite their size).Have any official patches been applied, if necessary?
No official patches mentioned by PCGamingWiki.
Is the game data in the root of the ZIP (unless game does not work that way)?
Yes.
Is the entry in the right variant file (i.e. Freeware)?
Yes.
Have digital versions (Steam, GOG) been checked for matching?
Unfortunately a few files do not match for GOG/Steam, according to the store DBs. I'm unable to add variants.
Can the game benefit from using embedded data or embedded patches in the datfile?
Yes, I added it to
TOONSTRK.CFG.Can DoDAT build the game from the install media?
Yes.
If the game requires a yml in the DOSZ, has it been added to the yml folder in the repo?
Not applicable.
Are there .PIF or .ICO or Win32 .EXE files that could be excluded?
Yes, I removed PIF files.
Do the file timestamps match the installation media?
No, I added them.
Does the DOSZ run standalone?
Yes.
For CD games, can the game be set up to run without a CD mounted?
Yes, with all files extracted and the path in
TOONSTRK.CFGedited toC:\. I removed the disc images that were included, kept theMISCfiles in their folder just in case, and didn't include theBURSTfolder which looked unnecessary.For games which include CD images, is there a smaller installation variant that offers the same features but needs less files?
Not applicable.
Can the game benefit from using CHDtoOGG?
There are no audio tracks.
Is the game creating a swap file in the .pure.zip that could be avoided by increasing memory size? Or is it creating other bloated files that could be prevented by adding them in the DOSZ?
No.
Does the DOSC contain problematic data (i.e. copyright issue)?
No.
Does the DOSC have copy protection removed, if possible?
Not applicable.
Is the game running at the correct speed? Is CPU year specified?
No CPU setting was specified. I left it uncapped since surprisingly it increased the FPS on the title screen beyond 1998. Maybe it affects somewhere in-game as well.
Is the DOSC auto-running and skipping past any obstructions? Does it use WAITMODECHANGE if possible?
Yes, but I updated it to WAITMODECHANGE.
Does the game have MT-32 support? If so, is it correctly using MT-32 (old) or CM-32L (new), going by the Vogons Wiki?
No.
Does the game have General MIDI support?
No.
Is the game set up to run with the best quality graphics options by default?
Yes, from the automatic detection.
For certain old games only - are the graphics/audio improved by specifying video_card: pcjr, tandy, or generic_cga?
Not applicable.
Does the game have a mouse cursor that benefits from enabling input_directmouse?
No, it doesn't work with this game.
Does a game with separate episodes/executables have the options named and ordered properly in the DOSZ? Do they use the run_utility feature?
Not applicable.
Does the game share saves with a sequel, expansion, etc? If so, is it updated to use the .savename feature?
Not applicable.
Comment
Summary of changes:
Unmentioned in the checklist: