Repository navigation
Conversation
The Linux CEC framework broadcasts <Report Physical Address> once a logical address is claimed. The Amlogic driver does not, and libCEC skips it when the address is already known at registration. The tested TV then did not route its remote keys to the box for about 12 seconds.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux CEC framework broadcasts as soon as a logical address is claimed. The Amlogic driver behind the AOCEC adapter does not. When the address is already known at registration, as it is with this adapter whenever the driver reports a valid one, OnRegister skips SetPhysicalAddress and nothing reports it. The tested TV then did not route its remote keys to the box until it queried the device on its own.
With the AOCEC adapter, OnRegister now broadcasts the address of each device of the client in that case. Other adapters are unchanged, so the Linux adapter does not send it twice. The address comes from the libCEC configuration, so an address set by the client is reported as well.
Tested on a Ugoos AM9 (S905X5, Linux 6.12) connected to a TV with a soundbar on the bus, with Kodi. Before, the first remote key reached libCEC 12.2 s after the connection was opened. With the change the box reported its address 0.3 s after the connection was opened and the first key reached libCEC after 3.5 s. The test build also carried a driver fix that retries transmissions lost to collisions on this bus.