Skip to content

pre-commit: pytest-summary-ingest hook always fails (asap-summary-ingest/tests/ does not exist) #898

Open

Description

@milindsrivastava1997

The pytest-summary-ingest hook in .pre-commit-config.yaml runs:

pip install -q -e asap-common/dependencies/py/promql_utilities/ && python3 -m pytest asap-summary-ingest/tests/

asap-summary-ingest/ is not in the repo, so pytest fails every time the hook triggers, i.e. on any commit that touches asap-common/dependencies/py/. Commits then need SKIP=pytest-summary-ingest.

The hook has a side effect too: its pip install -e repoints the developer's installed promql_utilities at whatever checkout or worktree ran the commit. That install breaks when the worktree is removed.

Fix: delete the hook, or point it at tests that exist. If it stays, drop the pip install -e from the hook, or isolate it, e.g. language: python with additional_dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions