Repository navigation
Add canonical versioned label population keys - #663
Merged
Merged
Conversation
# Conflicts: # data_plane/src/precompute_engine/maintenance_runtime.rs
zzylol
marked this pull request as ready for review
September 11, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing runtime label fingerprints concatenate unescaped
name=value;fragments, so one labela="b;c=d"aliases two labelsa="b", c="d". This adds a versioned, canonical codec for the existing sorted label map in the shared grouping module.The codec serializes ordered pairs as JSON and Base64, preserving delimiters, Unicode, empty populations and embedded control characters. Decoding rejects duplicate names, noncanonical ordering/serialization and unknown versions. No new DTO is introduced. Keys remain scoped by existing summary/data definitions and do not replace schema or partition identity.
Before: no shared unambiguous population-key codec was available for the next group-aware maintenance consumer. After: consumers can explicitly adopt one versioned encoding. Existing GroupingProjection serde and table-value codecs remain compatible; DP routing and persisted legacy keys are not migrated by this PR.
Validation: collision, ordering, exact serde roundtrip and malformed/duplicate/version tests pass. Existing grouping compatibility tests are included. No runtime or performance claim; explicit routing migration remains follow-up.