Repository navigation
chore(parser): pin backend PromQL parser revision - #603
Merged
Merged
Conversation
zzylol
force-pushed
the
chore/pin-promql-parser-d7606436
branch
from
September 10, 2026 21:25
9ab631b to
e14930b
Compare
zzylol
changed the title
zzylol
force-pushed
the
chore/pin-promql-parser-d7606436
branch
from
September 10, 2026 21:33
06e4aae to
e14930b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Backend root, control-plane, and data-plane parsing previously resolved older parser versions and duplicate direct declarations. They need one reproducible parser source before the VictoriaMetrics frontend migration lands.
What
Pin the workspace parser to ProjectASAP/promql-parser commit
d7606436bde05efe19c5398fe2122faa49062f7d. Control plane and data plane inherit that dependency withworkspace = true.How
The workspace root owns the git URL and immutable revision. Member crates declare only the workspace dependency, preventing direct dependency drift.
Before this PR
Backend parsing included crates.io 0.5 and the older ProjectASAP fork revision
c51beafb.After this PR
Every direct backend parser consumer resolves v0.10 from
d7606436. The stacked VictoriaMetrics migration removes the remaining old Planner frontend and MetricsQL parser paths.Verification
cargo check -p control_plane --libcargo fmt -p control_plane -- --checkgit diff --checkDependencies and limitations
Planner #385 updates
asap-frontend-promqlto the same revision. Backend #600 is stacked on this PR and removes the remaining duplicate transitive parser path. This dependency pin alone does not claim acceleration support for newly parsed functions.