Repository navigation
fix(control-plane): preserve query semantics through physical planning - #449
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MVP demo must preserve the query meaning selected by ASAPPlanner and must fail closed when evidence is insufficient.
What
Physical planning no longer rewrites quantile/frequency intent through an incompatible sketch override; bare global HLL count is cumulative; the full-stack HLL regression is enabled; compiler documentation distinguishes implemented behavior from deferred APIs.
How
Keep statistic semantics owned by the Planner query contract, constrain override handling, and align HLL merge behavior with the emitted plan.
Before this PR
An override could change the requested statistic, and the global-count regression was disabled, allowing documented and executable behavior to diverge.
After this PR
A query retains its planned statistic through physical planning, and global HLL count is regression-tested end to end.
Evidence
Execution example: the controller emits an HLL global-count plan and the backend merges results across SIDs. Visual and performance evidence are not applicable.
Verification
cargo test --workspace --lib— 927 passed, 2 ignored.live_serve_hll_global_count_merges_across_sids— passed.cargo check -p control_plane, package formatting, andgit diff --check— passed.Architectural decisions
Planner owns query semantics; physical overrides may select compatible implementations but may not redefine the operation.
Limitations and follow-up
This PR deliberately does not migrate to the latest Planner IR. That staged migration begins in #450 and is tracked by #448.
Human review — do not complete with an agent