Repository navigation
fix(lifecycle): sync normalized demand APIs - #324
Merged
Merged
Conversation
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASAPQuery-backend's MVP physical compiler must consume the current ASAPPlanner lifecycle API. Stale demand types and fixture field names prevented the authoritative Planner workspace and downstream control plane from compiling together.
What
Lifecycle costing now reads normalized expected demand, and the lifecycle end-to-end fixture uses the current explicit runtime capability fields.
How
Use
DemandEstimate.expected_ratedirectly, remove the deletedExpectedDemandadapter, and update the fixture without changing Planner selection semantics.Before this PR
The lifecycle code referenced removed APIs, so the latest Planner contract could not be built or consumed downstream.
After this PR
Planner lifecycle selection compiles against the normalized demand model, and downstream compilation can pin one coherent Planner revision.
Evidence
Execution evidence: the complete Planner workspace builds and tests successfully. Visual and performance evidence are not applicable.
Verification
cargo test --workspace --all-targets— passed.summary_maintenance_lifecycle_e2eexercises the current runtime capability contract.cargo fmt --all -- --check— passed.Architectural decisions
No new public interface. This is a compatibility correction to the existing normalized-demand and lifecycle contracts.
Limitations and follow-up
Downstream adoption is staged in ProjectASAP/ASAPQuery-backend#453 and ProjectASAP/ASAPCollector#564.
Human review — do not complete with an agent