Skip to content

test(promql): re-baseline the corpus coverage tripwire (#112) - #114

Merged
zzylol merged 1 commit into
mainfrom
fix/112-corpus-tripwire
Jul 9, 2026
Merged

zzylol merged 1 commit into
mainfrom
fix/112-corpus-tripwire

Conversation

@zzylol

@zzylol zzylol commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Closes #112.

The coverage floors in promql_corpus.rs were set from figures that predate the #40 / #43–#51 / #84 / #86 / #89 coverage work.

comment claimed actual on main
docs lowered ≈29 48 (of 49)
testdata lowered ≈574 1502 (of 1823)
testdata rejected 1014 86
testdata unparseable 235 235 ✓

td.lowered >= 520 therefore passed with ~980 queries of slack: lowering could have broken for 65% of the testdata corpus without turning the test red.

Change

Floors raised to ~1% under the measured values (docs >= 47, td >= 1485), and the stale comment replaced with the current numbers plus a pointer to what the residual failures are (#108 parser gaps, #109 lowering gaps).

Verification

Confirmed the assert is actually live, rather than assuming it:

# floor temporarily set to 1503 (one above actual)
testdata lowering coverage regressed: Tally { lowered: 1502, rejected: 86, unparseable: 235 }
test result: FAILED

# restored to 1485
test result: ok

cargo clippy --all-targets clean.

🤖 Generated with Claude Code

The floors were set from figures that predated the #40/#43-#51/#84/#86/#89
coverage work: the comment claimed testdata≈574 lowered / 1014 rejected,
where the corpus now lowers 1502 / rejects 86. `td.lowered >= 520` therefore
passed with ~980 queries of slack — lowering could break for 65% of the
corpus without turning the test red.

Raise both floors to ~1% under the measured values and record what the
remaining failures are, so the numbers get ratcheted rather than drift.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@zzylol
zzylol merged commit 423ffe0 into main Jul 9, 2026
1 check passed
@zzylol
zzylol deleted the fix/112-corpus-tripwire branch July 9, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(promql): corpus coverage tripwire is ~3x stale (asserts 520 lowered, actual 1502)

1 participant