Repository navigation
test(promql): re-baseline the corpus coverage tripwire (#112) - #114
Merged
Merged
Conversation
The floors were set from figures that predated the #40/#43-#51/#84/#86/#89 coverage work: the comment claimed testdata≈574 lowered / 1014 rejected, where the corpus now lowers 1502 / rejects 86. `td.lowered >= 520` therefore passed with ~980 queries of slack — lowering could break for 65% of the corpus without turning the test red. Raise both floors to ~1% under the measured values and record what the remaining failures are, so the numbers get ratcheted rather than drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.
The coverage floors in
promql_corpus.rswere set from figures that predate the #40 / #43–#51 / #84 / #86 / #89 coverage work.maintd.lowered >= 520therefore passed with ~980 queries of slack: lowering could have broken for 65% of the testdata corpus without turning the test red.Change
Floors raised to ~1% under the measured values (
docs >= 47,td >= 1485), and the stale comment replaced with the current numbers plus a pointer to what the residual failures are (#108 parser gaps, #109 lowering gaps).Verification
Confirmed the assert is actually live, rather than assuming it:
cargo clippy --all-targetsclean.🤖 Generated with Claude Code