Repository navigation
feat(collector): consume compiled physical plans - #561
Merged
Merged
Conversation
zzylol
force-pushed
the
feat/physical-plan-consumption
branch
from
September 1, 2026 00:47
4e7cfc3 to
304b940
Compare
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MVP Collector must consume ASAPQuery's compiled physical plan rather than parse query intent or choose a sketch locally.
What
Adds a strict Rust
CollectorPlandecoder/validator, behavioral tests, and documentation for the implemented consumption boundary.How
Decode the versioned plan, validate target/materialization fields as one atomic contract, derive stable aggregation identity, and expose only fully supported configurations.
Before this PR
Collector configuration was described aspirationally, but there was no typed runtime consumer for the compiled plan.
After this PR
Supported compiled materializations can be validated and converted into Collector runtime configuration; malformed or unsupported plans fail closed.
Evidence
Execution example: integration tests cover valid plan consumption and malformed/unsupported rejection. Visual and performance evidence are not applicable.
Verification
cargo test --manifest-path asap-precompute-rs/Cargo.toml --test collector_plan— passed.git diff --check— passed.Architectural decisions
ASAPQuery owns physical planning; Collector performs strict validation and execution only.
Limitations and follow-up
Stacked on #560. This PR does not yet connect the decoder to the production OpAMP transport.
Human review — do not complete with an agent