Skip to content

feat(collector): consume compiled physical plans - #561

Merged
zzylol merged 1 commit into
mainfrom
feat/physical-plan-consumption
Sep 2, 2026
Merged

zzylol merged 1 commit into
mainfrom
feat/physical-plan-consumption

Conversation

@zzylol

@zzylol zzylol commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Why

The MVP Collector must consume ASAPQuery's compiled physical plan rather than parse query intent or choose a sketch locally.

What

Adds a strict Rust CollectorPlan decoder/validator, behavioral tests, and documentation for the implemented consumption boundary.

How

Decode the versioned plan, validate target/materialization fields as one atomic contract, derive stable aggregation identity, and expose only fully supported configurations.

Before this PR

Collector configuration was described aspirationally, but there was no typed runtime consumer for the compiled plan.

After this PR

Supported compiled materializations can be validated and converted into Collector runtime configuration; malformed or unsupported plans fail closed.

Evidence

Execution example: integration tests cover valid plan consumption and malformed/unsupported rejection. Visual and performance evidence are not applicable.

Verification

Architectural decisions

ASAPQuery owns physical planning; Collector performs strict validation and execution only.

Limitations and follow-up

Stacked on #560. This PR does not yet connect the decoder to the production OpAMP transport.

Human review — do not complete with an agent

  • The MVP boundary is correct.
  • New conceptual layers or public interfaces are necessary.
  • The before/after description matches the intended product behavior.
  • Human reviewer:
  • Decision and rationale:

@zzylol
zzylol force-pushed the feat/physical-plan-consumption branch from 4e7cfc3 to 304b940 Compare September 1, 2026 00:47
@zzylol
zzylol deleted the branch main September 2, 2026 17:17
@zzylol zzylol closed this Sep 2, 2026
@zzylol zzylol reopened this Sep 2, 2026
@zzylol
zzylol changed the base branch from fix/mvp-evidence-gates to main September 2, 2026 17:18
@zzylol
zzylol merged commit 31efa84 into main Sep 2, 2026
1 check passed
@zzylol
zzylol deleted the feat/physical-plan-consumption branch September 2, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant