Skip to content

Accelerated MAISI and make it compatible with previous DDPM - #1953

Merged
Can-Zhao merged 69 commits into
Project-MONAI:mainfrom
Can-Zhao:maisi
Mar 19, 2025
Merged

Can-Zhao merged 69 commits into
Project-MONAI:mainfrom
Can-Zhao:maisi

Conversation

@Can-Zhao

@Can-Zhao Can-Zhao commented Mar 11, 2025 •

Copy link
Copy Markdown
Contributor

Let MAISI tutorial work for more than one version name, and make it compatible with previous DDPM.
Inference Tested with DDPM and RFlow.
Training tested for DDPM and RFlow
Some updates come from isort and black

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Can-Zhao and others added 5 commits March 11, 2025 20:45
…Tsted with DDPM, not with rflow in this PR

Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Can-Zhao and others added 14 commits March 11, 2025 20:57
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
Can-Zhao marked this pull request as ready for review March 11, 2025 23:42
Comment thread generation/maisi/README.md Resolved
pre-commit-ci Bot and others added 2 commits March 14, 2025 19:56
Signed-off-by: Can-Zhao <canz@nvidia.com>
@KumoLiu
KumoLiu requested a review from binliunls March 16, 2025 08:13

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@KumoLiu
KumoLiu enabled auto-merge (squash) March 19, 2025 03:47
@Can-Zhao
Can-Zhao marked this pull request as draft March 19, 2025 03:54
auto-merge was automatically disabled March 19, 2025 03:54

Pull request was converted to draft

Can-Zhao and others added 5 commits March 19, 2025 04:18
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
Can-Zhao marked this pull request as ready for review March 19, 2025 05:58
@Can-Zhao
Can-Zhao marked this pull request as draft March 19, 2025 06:17
Signed-off-by: Can-Zhao <canz@nvidia.com>
Signed-off-by: Can-Zhao <canz@nvidia.com>
@Can-Zhao
Can-Zhao marked this pull request as ready for review March 19, 2025 06:28
@Can-Zhao
Can-Zhao merged commit 9f6d19f into Project-MONAI:main Mar 19, 2025
@Can-Zhao
Can-Zhao deleted the maisi branch March 19, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants