Skip to content

Refactor MAISI tutorial, migrate GenerativeAI import - #1779

Merged
KumoLiu merged 38 commits into
Project-MONAI:mainfrom
Can-Zhao:refactor_maisi
Aug 15, 2024
Merged

KumoLiu merged 38 commits into
Project-MONAI:mainfrom
Can-Zhao:refactor_maisi

Conversation

@Can-Zhao

@Can-Zhao Can-Zhao commented Aug 12, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #1772 .

Description

Refactor MAISI tutorial, migrate GenerativeAI import to monai core.
Add inference script.
Correct logging format.
VAE training notebook tested.
Diffusion training notebook tested.
ControlNet training notebook tested.
Inference notebook tested.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mingxin-zheng
mingxin-zheng previously approved these changes Aug 12, 2024
@mingxin-zheng
mingxin-zheng dismissed their stale review August 12, 2024 08:02

MR is still in draft state. Maybe there are some more refactors

Can-Zhao and others added 16 commits August 12, 2024 14:04
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao
Can-Zhao marked this pull request as ready for review August 12, 2024 17:54
Can-Zhao and others added 8 commits August 12, 2024 18:23
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…k to save time

Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
@Can-Zhao

Can-Zhao commented Aug 13, 2024 •

Copy link
Copy Markdown
Contributor Author

To pass CI, it requires monai core ControlNetMaisi to remove generative dependency first.

@mingxin-zheng

Copy link
Copy Markdown
Contributor

To pass CI, it requires monai core ControlNetMaisi to remove generative dependency first.

It seems we can re-run it after this PR is merged:
Project-MONAI/MONAI#8005

Comment thread generation/maisi/scripts/inference.py Resolved
Comment thread generation/maisi/README.md Resolved
Comment thread generation/maisi/scripts/utils.py Resolved
@KumoLiu
KumoLiu merged commit 62f8ff8 into Project-MONAI:main Aug 15, 2024
@KumoLiu

KumoLiu commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Hi @Can-Zhao, I find there is still one place need to be updated in the maisi: https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/config_maisi_diff_model.json#L3

@Can-Zhao

Copy link
Copy Markdown
Contributor Author

Hi @Can-Zhao, I find there is still one place need to be updated in the maisi: https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/config_maisi_diff_model.json#L3

Submitted a PR for it #1786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor MAISI Network with New Generative AI Components

4 participants