You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add bending energy and diffusion regularizer demo #1587
Describe the solution you'd like
Add the demo, similar to the one here.
Describe alternatives you've considered
/
Additional context
I'm not sure if @ebrahimebrahim would mind me doing both bending energy and diffusion in the same notebook, or we could work on demos for the two losses separately. I wouldn't mind doing both but let me know what your preference is! :)
In addition to the existing stuff in my personal demo, I think it would also be helpful to include explanations of some of the examples used for unit testing.
After this, need to update the docstring in MONAI core for both losses.
I agree that covering bending energy and diffusion in the same notebook makes sense.
I think that the scale invariance and scaling law stuff in the personal demo that you and I put together should not go into the tutorials repo. Or at least it should be simplified before going in, since it was originally designed to verify that an algorithm was behaving correctly and not really designed to be tutorial material. Someone interested in a tutorial on bending/diffusion loss functions would just want to see an example DDF and see the loss functions applied. Then we can be like "here's what normalize=True does" and show the effect.
Thanks for posting this task and for any work that you end up doing on it :D
I agree that covering bending energy and diffusion in the same notebook makes sense.
I think that the scale invariance and scaling law stuff in the personal demo that you and I put together should not go into the tutorials repo. Or at least it should be simplified before going in, since it was originally designed to verify that an algorithm was behaving correctly and not really designed to be tutorial material. Someone interested in a tutorial on bending/diffusion loss functions would just want to see an example DDF and see the loss functions applied. Then we can be like "here's what normalize=True does" and show the effect.
Thanks for posting this task and for any work that you end up doing on it :D
Thank you! And I agree that scaling laws should not go into the tutorial repo. With that being said, I think what are necessary to include in this tutorial would be
Formula for bending energy and diffusion,
Demonstration that bending energy is not scale invariant (a visual example just like the one you provided in your notebook would suffice), diffusion is not scale invariant in some cases (maybe display examples of these cases), and
How both losses are made invariant by specifying normalize=True.
And the emphasis should be on how to use these two losses instead of on the more technical aspects.
Activity
ebrahimebrahim commentedon Dec 5, 2023
I agree that covering bending energy and diffusion in the same notebook makes sense.
I think that the scale invariance and scaling law stuff in the personal demo that you and I put together should not go into the tutorials repo. Or at least it should be simplified before going in, since it was originally designed to verify that an algorithm was behaving correctly and not really designed to be tutorial material. Someone interested in a tutorial on bending/diffusion loss functions would just want to see an example DDF and see the loss functions applied. Then we can be like "here's what
normalize=Truedoes" and show the effect.Thanks for posting this task and for any work that you end up doing on it :D
kvttt commentedon Dec 5, 2023
Thank you! And I agree that scaling laws should not go into the tutorial repo. With that being said, I think what are necessary to include in this tutorial would be
normalize=True.And the emphasis should be on how to use these two losses instead of on the more technical aspects.
I will go ahead and put together a draft :)
1587 add regularizer demo (#1589)
1587 add regularizer demo (Project-MONAI#1589)