Skip to content

SimpleCRF install fix - #725

Closed
andreped wants to merge 1 commit into
Project-MONAI:mainfrom
andreped:main
Closed

andreped wants to merge 1 commit into
Project-MONAI:mainfrom
andreped:main

Conversation

@andreped

@andreped andreped commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

As mentioned in this thread, a fix for installing SimpleCRF that uses precompiled binaries was developed. A temporary PyPI project was made, which means that installing SimpleCRF on all platforms is much easier, and solves the issue mentioned in the issue #719. The PyPI project is called SimpleCRF-binaries.

I have made the necessary modifications to the install procedure of MONAI Label to use the new package.

However, run some unit tests just to verify that the package installs and works as expected with MONAI Label.

@SachidanandAlle

Copy link
Copy Markdown
Collaborator

Thanks for taking care of this.. however i just tried uninstall simple crf and installed new binaries.. i see some issue.. the required python modules like maxflow, denseCRF, denseCRF3D are not available

@andreped

andreped commented Apr 5, 2022 •

Copy link
Copy Markdown
Contributor Author

@SachidanandAlle It is strange, because I have run tests to assess this and they all were successful:
https://github.com/andreped/SimpleCRF/actions/runs/2096086307

The unit tests I did can be found in this workflow: https://github.com/andreped/SimpleCRF/blob/binaries/.github/workflows/CI-build.yaml#L44

Note that I am working in the binaries branch to produce these wheels.

I will do some testing on a local macos 10.13 desktop to see if I can reproduce the issue.

@SachidanandAlle

Copy link
Copy Markdown
Collaborator

@SachidanandAlle It is strange, because I have run tests to assess this and they all were successful: https://github.com/andreped/SimpleCRF/actions/runs/2096086307

The unit tests I did can be found in this workflow: https://github.com/andreped/SimpleCRF/blob/binaries/.github/workflows/CI-build.yaml#L44

Note that I am working in the binaries branch to produce these wheels.

I will do some testing on a local macos 10.13 desktop to see if I can reproduce the issue.

the issue was numpy again... need latest numpy.. and i couldn't use 1.21.5

@SachidanandAlle

Copy link
Copy Markdown
Collaborator

#726

@andreped

andreped commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

the issue was numpy again... need latest numpy.. and i couldn't use 1.21.5

Oh, but then that is easy to fix. However, the numpy version that is used with MONAI Label should rather be defined there, than me requiring a newer version of numpy in SimpleCRF.

Nonetheless, due to the licensing issue, I guess this PR will be frozen for now, and may become relevant again in the future.

@andreped

andreped commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

Due to the licensing issue with SimpleCRF, this PR is not longer needed, as SimpleCRF will be removed from MONAI Label.

Closing for now.

@andreped andreped closed this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants