Repository navigation
fix(nets): thread ResNet norm/act into residual blocks and guard non-affine init #9028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aymuos15
wants to merge
11
commits into
Project-MONAI:dev
Choose a base branch
from
aymuos15:fix/resnet-norm-act-threading
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
928f3af
fix(nets): thread ResNet norm/act into residual blocks and guard non-…
aymuos15 7722c9a
Merge branch 'dev' into fix/resnet-norm-act-threading
aymuos15 f57cc91
Merge branch 'dev' into fix/resnet-norm-act-threading
aymuos15 5f3e2b0
fix(nets): make ResNet block norm/act threading opt-in for backward c…
aymuos15 f2f990d
Merge branch 'dev' into fix/resnet-norm-act-threading
ericspod 71c0aaa
Merge remote-tracking branch 'upstream/dev' into fix/resnet-norm-act-…
aymuos15 f88833a
Fix block_norm_act docstring to match downsample behavior
aymuos15 d72a437
Only forward act to blocks when block_norm_act is enabled
aymuos15 f565922
Use each stage's channel count when threading norm
aymuos15 a359667
Assert shortcut-B downsample stays batch norm when opt-in is off
aymuos15 2f2cb31
Test DAF3D bottleneck act forwarding
aymuos15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle channel-dependent activations.
act=("prelu", {"num_parameters": 32})constructs a block withplanes=32, but its inherited forward path also applies that activation to 64 channels. The forward pass fails because PReLU requires one parameter or one per channel. (docs.pytorch.org)Use activations sized for each width, or reject and document this configuration.