Skip to content

7601 fix mlflow artifacts - #7604

Merged
KumoLiu merged 9 commits into
Project-MONAI:devfrom
binliunls:7601-fix-mlflow-artifacts
Apr 12, 2024
Merged

KumoLiu merged 9 commits into
Project-MONAI:devfrom
binliunls:7601-fix-mlflow-artifacts

Conversation

@binliunls

@binliunls binliunls commented Apr 1, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #7601 .

Description

Support not save artifacts.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

binliunls and others added 4 commits April 1, 2024 14:54
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls
binliunls requested a review from Nic-Ma April 7, 2024 11:04

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, put minor comments inline.
Please remember to update the associated tutorial notebook.

Thanks.

Comment thread monai/bundle/utils.py Resolved
Comment thread monai/bundle/workflows.py Resolved
Comment thread monai/bundle/scripts.py Resolved
@Nic-Ma

Nic-Ma commented Apr 10, 2024 •

Copy link
Copy Markdown
Contributor

Hi @KumoLiu ,

Could you please help include this bug fix PR in the MONAI 1.3.1rc3 release?

Thanks in advance.

Signed-off-by: binliu <binliu@nvidia.com>
@KumoLiu

KumoLiu commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

/build

@KumoLiu

KumoLiu commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

/build

@KumoLiu
KumoLiu merged commit da3ecdd into Project-MONAI:dev Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default MLFlow tracking cannot set if tracking the config artifacts

3 participants