Skip to content

Signalfillempty set track_meta to True - #7089

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
matt3o:signalfillempty_meta
Oct 5, 2023
Merged

wyli merged 3 commits into
Project-MONAI:devfrom
matt3o:signalfillempty_meta

Conversation

@matt3o

@matt3o matt3o commented Oct 5, 2023 •

Copy link
Copy Markdown
Contributor

Related to #7011. I was using the Signalfillemptyd (based on Signalfillempty) transform in monailabel and found out, it currently allows no inversion.
When digging deeper I realized that SignalFillEmpty just throws away the meta information.
With the simple addition of track_meta=True it works as expected.
I hope it has no other impact, but I honestly don't know.

@wyli would be cool if we can add this to MONAI 1.3.0, thanks! I can also rework Signalfillempty to just accept any datatype, if that would the more appropriate approach.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Documentation updated, tested make html command in the docs/ folder.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

Signed-off-by: Matthias Hadlich <matthiashadlich@posteo.de>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
wyli marked this pull request as ready for review October 5, 2023 15:22
@wyli

wyli commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) October 5, 2023 15:22
@wyli

wyli commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@wyli

wyli commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli merged commit 100db27 into Project-MONAI:dev Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants