Skip to content

Fix unused kernel_size in ResBlock - #6999

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
KumoLiu:resblock
Sep 18, 2023
Merged

wyli merged 2 commits into
Project-MONAI:devfrom
KumoLiu:resblock

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Sep 18, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #6998

Description

Fixed unused kernel_size in ResBlock.
Fixed untested norm in unit tests.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
KumoLiu requested review from Nic-Ma, ericspod and wyli September 18, 2023 10:28

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli

wyli commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) September 18, 2023 11:22
@wyli
wyli merged commit 5a644e4 into Project-MONAI:dev Sep 18, 2023
@KumoLiu
KumoLiu deleted the resblock branch September 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused kernel_size in ResBlock

2 participants