Skip to content

6894 update rank filter - #6895

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
wyli:6894-rank-filter
Aug 21, 2023
Merged

wyli merged 3 commits into
Project-MONAI:devfrom
wyli:6894-rank-filter

Conversation

@wyli

@wyli wyli commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Fixes #6894

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli requested a review from mingxin-zheng August 21, 2023 13:23
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

@mingxin-zheng mingxin-zheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli .

@wyli
wyli marked this pull request as ready for review August 21, 2023 13:58
@wyli

wyli commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli
wyli enabled auto-merge (squash) August 21, 2023 14:16
@wyli

wyli commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@wyli

wyli commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli force-pushed the 6894-rank-filter branch from e423f09 to 71a001e Compare August 21, 2023 18:12
@wyli

wyli commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli
wyli merged commit 2daabf9 into Project-MONAI:dev Aug 21, 2023
@wyli
wyli deleted the 6894-rank-filter branch September 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RankFilter in a single gpu environment

2 participants