Skip to content

default val for config parsed content - #6756

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
wyli:config_default
Jul 26, 2023
Merged

wyli merged 3 commits into
Project-MONAI:devfrom
wyli:config_default

Conversation

@wyli

@wyli wyli commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Fixes #6755

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
wyli requested review from KumoLiu, Nic-Ma and ericspod July 21, 2023 20:31
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli force-pushed the config_default branch from 90bf848 to 55e6c2e Compare July 24, 2023 17:43

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

wyli added 2 commits July 26, 2023 07:06
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
wyli enabled auto-merge (squash) July 26, 2023 06:12
@wyli

wyli commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli
wyli merged commit 3b56e7f into Project-MONAI:dev Jul 26, 2023
@wyli
wyli deleted the config_default branch July 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get parsed content with default attribute error

2 participants