Skip to content

6612-support-mlflow-data-tracking - #6616

Merged
wyli merged 36 commits into
Project-MONAI:devfrom
binliunls:6612-support-mlflow-data-tracking
Jul 19, 2023
Merged

wyli merged 36 commits into
Project-MONAI:devfrom
binliunls:6612-support-mlflow-data-tracking

Conversation

@binliunls

Copy link
Copy Markdown
Contributor

Fixes #6612 .

Description

Add the dataset tracking support to MLFlow handler.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

binliunls and others added 22 commits June 14, 2023 13:10
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls binliunls changed the title [WIP]6612-support-mlflow-data-tracking 6612-support-mlflow-data-tracking Jun 29, 2023
@binliunls
binliunls marked this pull request as ready for review June 29, 2023 16:23
@binliunls
binliunls requested review from Nic-Ma and wyli June 29, 2023 16:24
Comment thread tests/test_handler_mlflow.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
@wyli
wyli requested a review from ericspod July 4, 2023 13:21
Comment thread monai/bundle/utils.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread tests/test_handler_mlflow.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
@Nic-Ma
Nic-Ma requested a review from KumoLiu July 4, 2023 13:26
Comment thread monai/bundle/utils.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
binliunls added 6 commits July 5, 2023 08:24
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Comment thread monai/handlers/mlflow_handler.py Resolved
Comment thread monai/handlers/mlflow_handler.py Resolved
binliunls and others added 4 commits July 10, 2023 09:19
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Comment thread monai/handlers/mlflow_handler.py Resolved

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts LGTM, do we need to pending this one since the experimental features? cc @wyli, @Nic-Ma, @ericspod.

@wyli

wyli commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me, could you please confirm and resolve the comments?

@wyli
wyli enabled auto-merge (squash) July 19, 2023 06:52
@wyli
wyli merged commit 3247db0 into Project-MONAI:dev Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the MLFlfow data tracking in MONAI

4 participants