Skip to content

auto updates and merging 6339/6341/6346 - #6344

Merged
wyli merged 5 commits into
devfrom
auto-update
Apr 12, 2023
Merged

wyli merged 5 commits into
devfrom
auto-update

Conversation

@monai-bot

@monai-bot monai-bot commented Apr 12, 2023 •

Copy link
Copy Markdown
Contributor

Signed-off-by: monai-bot monai.miccai2019@gmail.com

closes #6339 (closes #6337)
closes #6341 (closes #6340 closes #6253)
closes #6345
closes #6247 (closes #6346)
closes #6348

monai-bot and others added 2 commits April 12, 2023 07:20
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
closes #6339 (closes #6337)
closes #6341 (closes #6340 closes #6253)


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Co-authored-by: binliunls <107988372+binliunls@users.noreply.github.com>
@wyli wyli changed the title auto updates auto updates and merging 6339/6341 Apr 12, 2023
@wyli

wyli commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

/build

Fixes #6247  .

### Description

It includes two changes:
- Project-MONAI/research-contributions#218
- Project-MONAI/research-contributions#213

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@wyli

wyli commented Apr 12, 2023 •

Copy link
Copy Markdown
Contributor

/integration-test
/build

@wyli wyli changed the title auto updates and merging 6339/6341 auto updates and merging 6339/6341/6346 Apr 12, 2023
@wyli
wyli enabled auto-merge (squash) April 12, 2023 10:12
@wyli
wyli disabled auto-merge April 12, 2023 11:00
@wyli

wyli commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

maybe there's some other issues, the tests are taking 1000 epochs https://github.com/Project-MONAI/MONAI/actions/runs/4677300504/jobs/8284640365 @mingxin-zheng

@wyli
wyli enabled auto-merge (squash) April 12, 2023 11:02
@wyli
wyli disabled auto-merge April 12, 2023 11:02
@wyli

wyli commented Apr 12, 2023 •

Copy link
Copy Markdown
Contributor

so the issue is that segresnet2d was skipped in the latest template, so the test cases changed to use dints, taking too many search iterations

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) April 12, 2023 11:56
@wyli
wyli merged commit 6b7b1e7 into dev Apr 12, 2023
@wyli
wyli deleted the auto-update branch April 12, 2023 12:36
@mingxin-zheng

mingxin-zheng commented Apr 12, 2023 •

Copy link
Copy Markdown
Collaborator

Thanks @wyli for identifying the issue. dints HPO requires overriding parameters like:

override_param = {
    "num_epochs": <num_epoch>,
    "num_epochs_per_validation": <num_epoch_val>,
    "num_iterations": <n_iter>,
    "num_iterations_per_validation": <n_iter_val>,
    "training#num_iterations": <train_n_iter>,
    "training#num_iterations_per_validation": <train_n_iter_val>,
    "searching#num_iterations": <search_n_iter>,
    "searching#num_iterations_per_validation": <search_n_iter_val>,
    "searching#num_warmup_iterations": <search_n_warmup>,
}

I will submit a PR to improve the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants