Skip to content

Fix sliding_window_inference - #6325

Merged
wyli merged 9 commits into
Project-MONAI:auto-updatefrom
KumoLiu:fix-sliding-window-inference
Apr 11, 2023
Merged

wyli merged 9 commits into
Project-MONAI:auto-updatefrom
KumoLiu:fix-sliding-window-inference

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

Fixes #6320 .

Description

Ensure sliding_window_inference can support output in dict and tuple format.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 2 commits April 10, 2023 16:14
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
KumoLiu requested review from Nic-Ma and wyli April 10, 2023 08:17
Signed-off-by: KumoLiu <yunl@nvidia.com>
Comment thread monai/inferers/utils.py Resolved
KumoLiu added 5 commits April 11, 2023 14:40
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyli Could you please help review this PR as you just refactored SlidingWindow?

Thanks in advance.

Comment thread monai/inferers/utils.py Resolved

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, I'll also verify the speed and merge this

@wyli
wyli changed the base branch from dev to auto-update April 11, 2023 07:52
Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
@wyli
wyli merged commit 0a4898a into Project-MONAI:auto-update Apr 11, 2023
@KumoLiu
KumoLiu deleted the fix-sliding-window-inference branch April 11, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sliding_window_inference cannot handle output in formats other than tensor

4 participants