Repository navigation
CAMP-TUM network contributions: Quicknat and Daf3D - #6306
Merged
Merged
Conversation
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
… 126 Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
ericspod
reviewed
Jun 22, 2023
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com>
Signed-off-by: Alexandra Marquardt <alexandra@MacBook-Pro-von-Alexandra.local>
Contributor
I fear I don't know what the torchscript bug is about. Why can't I use list expansion here? I appreciate any help! |
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
for more information, see https://pre-commit.ci
ge96lip
reviewed
Jun 24, 2023
wyli
reviewed
Jun 24, 2023
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com> Signed-off-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com>
Signed-off-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com>
wyli
reviewed
Jun 24, 2023
Signed-off-by: Wenqi Li <831580+wyli@users.noreply.github.com>
wyli
reviewed
Jun 24, 2023
Signed-off-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com>
Contributor
|
/build |
wyli
approved these changes
Jun 24, 2023
wyli
left a comment
Contributor
There was a problem hiding this comment.
thank you! merging this if the test pipelines work fine
wyli
enabled auto-merge (squash)
June 24, 2023 14:02
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Jun 26, 2023
Fixes Project-MONAI#5921 ### Description @Al3xand1a and @ge96lip implement DAF3D[1] and Quicknat[2] networks and test them in open-source and local datasets. We use as a baseline the pytorch codes available in [3] and [4] We are quite confident about the implementation, but feel free to contact us if you find errors. For any questions send us an email to ge45qix@mytum.de We have some questions for the contribution: For Quicknat: 1) we add the sequential class file in the networks folder because we do not know where to add it. 2) How do we include the squeeze and excitation requirement (sse and Csse) if it comes from a GitHub repository? https://github.com/ai-med/nn-common-modules/releases/download/v1.1/nn_common_modules-1.3-py3-none-any.whl For Daf3D 3) Are the overwritten blocks fine as they are? or do they have to be more flexible? For both: We run this command line (`./runtests.sh --quick --unittests --disttests`) but the error we are getting is not related to our changes, so we run our unit_test independently and they work. Same with documentation. [1] Deep Attentive Features for Prostate Segmentation in 3D Transrectal Ultrasound. Yi Wang, Haoran Dou, Xiaowei Hu, Lei Zhu, Xin Yang, Ming Xu, Jing Qin, Pheng-Ann Heng, Tianfu Wang, and Dong Ni. IEEE Transactions on Medical Imaging, 2019. [2] Roy, A. G., Conjeti, S., Navab, N., Wachinger, C., & Alzheimer's Disease Neuroimaging Initiative. (2019). QuickNAT: A fully convolutional network for quick and accurate segmentation of neuroanatomy. NeuroImage, 186, 713-727. [3] https://github.com/ai-med/quickNAT_pytorch [4] https://github.com/wulalago/DAF3D ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: ge96lip <73938628+ge96lip@users.noreply.github.com> Signed-off-by: vanessagd.2395 <vanessa.gonzalez-duque@eleves.ec-nantes.fr> Signed-off-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com> Co-authored-by: Alexandra Marquardt <alexandra@MBPvonAlexandra.fritz.box> Co-authored-by: Carlotta <carlotta.hoelzle@icloud.com> Co-authored-by: Alexandra Marquardt <alexandra@w223-2e-v4.eduroam.dynamic.rbg.tum.de> Co-authored-by: Vanessa <vanessa.gonzalezduque@ls2n.fr> Co-authored-by: ge96lip <73938628+ge96lip@users.noreply.github.com> Co-authored-by: “Vanessa <“vanessa.gonzalezduque@ls2n.fr”> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Alexandra Marquardt <alexandra@w192-1i-v4.eduroam.dynamic.rbg.tum.de> Co-authored-by: Al3xand1a <98582325+Al3xand1a@users.noreply.github.com> Co-authored-by: Alexandra Marquardt <alexandra@w217-4n-v4.eduroam.dynamic.rbg.tum.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5921
Description
@Al3xand1a and @ge96lip implement DAF3D[1] and Quicknat[2] networks and test them in open-source and local datasets. We use as a baseline the pytorch codes available in [3] and [4]
We are quite confident about the implementation, but feel free to contact us if you find errors. For any questions send us an email to ge45qix@mytum.de
We have some questions for the contribution:
For Quicknat:
https://github.com/ai-med/nn-common-modules/releases/download/v1.1/nn_common_modules-1.3-py3-none-any.whl
For Daf3D
For both:
We run this command line (
./runtests.sh --quick --unittests --disttests) but the error we are getting is not related to our changes, so we run our unit_test independently and they work. Same with documentation.[1] Deep Attentive Features for Prostate Segmentation in 3D Transrectal Ultrasound.
Yi Wang, Haoran Dou, Xiaowei Hu, Lei Zhu, Xin Yang, Ming Xu, Jing Qin, Pheng-Ann Heng, Tianfu Wang, and Dong Ni.
IEEE Transactions on Medical Imaging, 2019.
[2] Roy, A. G., Conjeti, S., Navab, N., Wachinger, C., & Alzheimer's Disease Neuroimaging Initiative. (2019). QuickNAT: A fully convolutional network for quick and accurate segmentation of neuroanatomy. NeuroImage, 186, 713-727.
[3] https://github.com/ai-med/quickNAT_pytorch
[4] https://github.com/wulalago/DAF3D
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.