Skip to content

Multithread batch sampler for PatchInferer - #6139

Merged
bhashemian merged 9 commits into
Project-MONAI:devfrom
bhashemian:multithread-patch-inference
Jul 15, 2023
Merged

bhashemian merged 9 commits into
Project-MONAI:devfrom
bhashemian:multithread-patch-inference

Conversation

@bhashemian

@bhashemian bhashemian commented Mar 13, 2023 •

Copy link
Copy Markdown
Member

Fixes #6138

Description

This PR makes the batch sampling of PatchInferer multi-threaded so that WSI inference (using WSI splitters) can leverage this to enhance performance.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

@bhashemian
bhashemian marked this pull request as ready for review June 6, 2023 18:36
@bhashemian bhashemian mentioned this pull request Jun 28, 2023
6 tasks done
@bhashemian
bhashemian marked this pull request as draft July 6, 2023 16:49
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
bhashemian force-pushed the multithread-patch-inference branch from 3fe72ed to a40b29a Compare July 10, 2023 18:12
@bhashemian
bhashemian marked this pull request as ready for review July 10, 2023 18:41
Comment thread monai/inferers/inferer.py Resolved
Comment thread monai/inferers/inferer.py Resolved
@bhashemian
bhashemian requested a review from KumoLiu July 13, 2023 15:00

@KumoLiu KumoLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update, LGTM.

@bhashemian

Copy link
Copy Markdown
Member Author

@ericspod any more comments here? Otherwise, we can merge it. Thanks

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drbeh I'm good here!

@wyli

wyli commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

/build

@bhashemian
bhashemian enabled auto-merge (squash) July 15, 2023 02:57
@bhashemian
bhashemian disabled auto-merge July 15, 2023 02:58
@bhashemian
bhashemian enabled auto-merge (squash) July 15, 2023 02:59
@bhashemian
bhashemian merged commit dc1bc77 into Project-MONAI:dev Jul 15, 2023
@bhashemian
bhashemian deleted the multithread-patch-inference branch July 15, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-threaded patch inference

4 participants